Skip to content

Conversation

@arnopo
Copy link
Collaborator

@arnopo arnopo commented Apr 2, 2024

This Pull request is a fix of the PR #549
The rvdev->notify_wait_cb is never initialized to NULL if not set by the user.
the proposal to fix is to initialize it to NULL and provide an API for the user to set it.

The issue is reproduced using flood-ping test in linux environment.

echo "################### run flood test #####################"
LD_LIBRARY_PATH=./bin/usr/local/lib:../../libmetal/build/lib/  ./bin/usr/local/bin/rpmsg-echo-shared &
sleep 1
LD_LIBRARY_PATH=./bin/usr/local/lib:../../libmetal/build/lib/  ./bin/usr/local/bin/msg-test-rpmsg-flood-ping-shared 1 || exit

@wyr8899 , pleas could you review it and give a feedback

The rvdev->notify_wait_cb is not initialized to NULL if
not set by the user.
Initialize it to NULL and provide an API for the application to set it.

Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@arnopo
Copy link
Collaborator Author

arnopo commented Apr 16, 2024

@xiaoxiang781216 : could I consider that if it is ok for you it is also ok for @wyr8899 ? The initial PR was related to NuttX, right?

@xiaoxiang781216
Copy link
Collaborator

yes, @wyr8899 and @CV-Bowen please verify the change.

@wyr-7
Copy link
Contributor

wyr-7 commented Apr 18, 2024

@arnopo @xiaoxiang781216 Sorry, I changed my account for some reasons and it is now approved.

@arnopo arnopo merged commit 7938516 into OpenAMP:main Apr 19, 2024
@arnopo arnopo added this to the Release V2024.04 milestone Apr 19, 2024
@arnopo arnopo deleted the FIX_#549 branch May 20, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants