apps: replace all zero address to RPMSG_ADDR_ANY #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
force-pushed
the
zero-address
branch
2 times, most recently
from
94919ea to
47ccda0
Compare
edmooring
approved these changes
May 13, 2020
Contributor
edmooring
left a comment
edmooring
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
arnopo
requested changes
May 13, 2020
Collaborator
arnopo
left a comment
arnopo
left a comment
There was a problem hiding this comment.
Just a minor update for test coverity then LGTM
apps/tests/msg/rpmsg-flood-ping.c
Outdated
| else | ||
| (void)rpmsg_create_ept(&lept, rdev, RPMSG_SERVICE_NAME, | ||
| APP_EPT_ADDR, dest, | ||
| RPMSG_ADDR_ANY, dest, |
Collaborator
There was a problem hiding this comment.
Could you keep this test unchanged? the idea here is to keep one test with a fixed source address to also test a use case with a fixed source address.
Collaborator
Author
There was a problem hiding this comment.
Done, but I change the local address from 0 to 1024 for the better compatibility.
xiaoxiang781216
force-pushed
the
zero-address
branch
2 times, most recently
from
d876f2f to
885c8ec
Compare
the example should demo the best practice for the endpoint creation Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
xiaoxiang781216
force-pushed
the
zero-address
branch
from
885c8ec to
1fad370
Compare
Collaborator
Author
|
@arnopo please merge this PR if you don't have more concern. |
arnopo
requested changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the example should demo the best practice for the endpoint creation
Signed-off-by: Xiang Xiao xiaoxiang@xiaomi.com