Skip to content

Conversation

@bentheredonethat
Copy link
Collaborator

@wmamills wmamills requested review from mhatle and wmamills June 26, 2025 15:38
Copy link
Collaborator

@wmamills wmamills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Drop layer compat from your PRs I will do my own
  • Separate common code changes in one PR and xilinx vendor changes in another

conf/layer.conf Outdated

# only for Xilinx petalinux
LAYERSERIES_COMPAT_openamp-layer += "langdale"
LAYERSERIES_COMPAT_openamp-layer = "scarthgap"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely not. We need to support master, latest release, LTS. We can and should support LTS-1 (now kickstone) when we can and I think we can now. We could not when LTS-1 was dunfell.

I will make my own PR to update this. Please take it out of this PR.

S = "${WORKDIR}/git/examples/linux/rpmsg-proxy-app"

RRECOMMENDS:${PN} = "kernel-module-rpmsg-char"
RRECOMMENDS:${PN} = "kernel-module-rpmsg-char kernel-module-rpmsg-ctrl"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These other common layer changes look OK to me for now. I will test when I get home (traveling this week)

However I would like to see this PR split between the common level changes and another PR for the stuff in the xilinx/ layer. I wont review the xilinx stuff so I don't want to sign off on it. Whatever you (ben) and Mark want in the Xilinx vendor dir is OK with me but it should be approved by the both of you.

bentheredonethat and others added 6 commits July 2, 2025 08:36
Move vendor specific logic to vendor specific layers

Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
Versal was recently split between versal and versal-net, add versal-net
as supported.

Signed-off-by: Mark Hatle <mark.hatle@amd.com>
Remove openamp support for Zynq-7000 Soc
Reasons for removing listed below:
1 - Removing redundant or unmaintained code from Linux tree
2 - Reduce technical debt carried by OpenAMP team
3 - OpenAMP drivers (remoteproc/rpmsg) for Zynq-7000 SoC is not
standardized on same code base as ZynqMP or Versal
4 - very few customer using openamp on Zynq-7000 SoC

For users of Zynq-7000 SoC the last working and tested release version
is rel-v2023.2

Signed-off-by: Rajiv Mohan <rajiv.mohan@amd.com>

- Fix typo in yocto-cmake-translation.bbclass.

Signed-off-by: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@amd.com>

classes/yocto-cmake-translation.bbclass: Remove comment referring to zynq7

Signed-off-by: Mark Hatle <mark.hatle@amd.com>
no_ipi_setup is not used with latest build setup so remove this

Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
Signed-off-by: Mark Hatle <mark.hatle@amd.com>
rpmsg-ctrl module required for demos to run

Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
Signed-off-by: Mark Hatle <mark.hatle@amd.com>
Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
@bentheredonethat
Copy link
Collaborator Author

@wmamills updated

also in our own layers we have moved the vendor specific SDT logic to internal layers so removed out all those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants