#262 #263
Merged
#262 #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the SNMP Server output plugin to support an enhanced OID mapping structure and adds improved error handling. The main changes include restructuring the YAML configuration to support nested OID definitions and adding comprehensive try-catch blocks with step-based error tracking throughout the JavaScript implementation.
Key Changes:
- Enhanced OID mapping structure in YAML config to support nested OID objects with additional metadata fields
- Added comprehensive error handling with step-based error messages across all functions
- Fixed logic bug in typeCasting function for integer range validation
- Added support for conditional authentication/authorization based on SNMP version
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 25 comments.
| File | Description |
|---|---|
| config/outputs.disabled/yaml/10.SNMPServer_Output.yaml | Updated OID mapping structure from string to nested object with "OID" field |
| config/objects/nOutput_SNMPServer.js | Complete refactor with error handling, bug fixes, support for OIDList templates, regex-based attribute matching, and enhanced data type handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Error so the snmpCommunity doesn't default to public for security reasons. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-project-automation
bot
moved this from Backlog
to Done
in Continuous Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change of nOutput_SNMPServer enabling the OID value for the alert as a regular expression. Also enabling a OIDList associated to the alert, instead of just the value.