Open
Conversation
Contributor
Author
|
@dwwest can I get a review here? |
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
dwwest
requested changes
Sep 5, 2025
Contributor
dwwest
left a comment
dwwest
left a comment
There was a problem hiding this comment.
Looks good! Just some docstring asks and want to keep cli up-to-date
| raise ValueError(f"inference_ckpt_path must exist, got {v}") | ||
| return v | ||
|
|
||
| def inference( |
Contributor
There was a problem hiding this comment.
Docstring for inference() please!
| ) | ||
|
|
||
| # Dump experiment runner | ||
| import json |
Contributor
There was a problem hiding this comment.
Why is this not up with other imports?
| update={"msa": colabfold_msa_settings} | ||
| ) | ||
| expt_config = expt_config.model_copy( | ||
| update={"dataset_config_kwargs": updated_dataset_config_kwargs} |
Contributor
There was a problem hiding this comment.
A little more documentation here, I don't totally understand what these arguments are that you're changing in the expt_config
Contributor
There was a problem hiding this comment.
Can you also add corresponding updates in cli/cofolding.py?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide a brief description of the PR's purpose here.
Fixes #74
Developers certificate of origin