Cleaning up the tutorial notebook#1
Merged
hmacdope merged 6 commits intoOpenADMET:mainfrom Oct 28, 2025
Merged
Conversation
1. fix import orders 2. update the outputs for better reviews 3. remove unused cell and whitespace
Contributor
Author
|
Hi @hmacdope . Can you please take a look at this PR? Thanks. |
hmacdope
approved these changes
Oct 28, 2025
Contributor
hmacdope
left a comment
hmacdope
left a comment
There was a problem hiding this comment.
I tested this, looks nice, thanks for the small edits. In general we won't take other tweaks as lots of reviewing burden.
Removed as we don't test in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a great starting point! Thanks for sharing.
Any feedback is appreciated.