Fix two issues in parallel_create_zero #107
Conversation
These tests have a few issues, but this patch fixes two of them: First, it adds the close paren on the 'copyout' clause that was missing. Second, it corrects the capitalization on the call to 'Test1', which was resulting in the test not being run properly. This does NOT fix the ill-formed use of `loop` however.
|
I approved them and will merge for now, I made a note for us to take a look at the loop |
Thanks! I was going to open an issue a little later, there are a few problems with the use of 'loop' as far as I can tell throughout the test suite, so I was going to summarize them best I could. Another one where if you give me guidance, I can put a patch together (or you're welcome to do so yourself). Note I'm finding these things running against |
|
Feel free to make patches and adjust the issue as needed. I'll be busy over the next couple of weeks, but i'll be able to help more once i'm available again. Also, just a heads up, PR #86 introduced quite a few changes across the suite. We're currently reviewing them and hope to merge soon. So if you run into something that seems off, it may already be in that PR. Thank you for taking a look at our suite :) |
Ah, thanks for that link! That is actually submitted from a coworker of mine (though on the fortran/flang team!). That actually DOES fix a handful of the problems I have (including much/most of #105). So I'd love to see that one merged! Thanks again! |
2 participants
These tests have a few issues, but this patch fixes two of them:
First, it adds the close paren on the 'copyout' clause that was missing.
Second, it corrects the capitalization on the call to 'Test1', which was resulting in the test not being run properly.
This does NOT fix the ill-formed use of
loophowever.