Add Thermal Limit Events to Thermal Manager#364
Conversation
| ### Parameters ### | ||
| @ Parameter for face temperature lower threshold in °C | ||
| param FACE_TEMP_LOWER_THRESHOLD: F64 default -20.0 id 0 | ||
|
|
||
| @ Parameter for face temperature upper threshold in °C | ||
| param FACE_TEMP_UPPER_THRESHOLD: F64 default 60.0 id 1 | ||
|
|
||
| @ Parameter for battery cell temperature lower threshold in °C | ||
| param BATT_CELL_TEMP_LOWER_THRESHOLD: F64 default -20.0 id 2 | ||
|
|
||
| @ Parameter for battery cell temperature upper threshold in °C | ||
| param BATT_CELL_TEMP_UPPER_THRESHOLD: F64 default 60.0 id 3 |
There was a problem hiding this comment.
This does look great to me! I will note though that on the Yearling satellites we consistently saw Face temperatures around -34C in eclipse, so I recommend throttling this event or adding some logic that will debounce it so we don't get too much spam.
There was a problem hiding this comment.
At what temps did we start seeing issues with hairsat?
There was a problem hiding this comment.
Thanks for the reminder on that actually! I would recommend changing that battery low temp threshold to something much more conservative, like 5C. If Lithium Ion batteries go below 0C they can still discharge but can suffer long term damage if you charge them at freezing temperatures.
As for the face temperatures, we still can generally read stalely down to -40C. Below that you start running into issues!
nateinaction
left a comment
There was a problem hiding this comment.
Looks correct, waiting on @Mikefly123 for thoughts on default values.
930b777 to
4b3b232
Compare
Add Thermal Limit Events to Thermal Manager
Description
Adds four events in Thermal Manager for when the face and battery temperature sensors read above or below a certain temperature. These thresholds are set with a parameter to the Thermal Manager.
These events can be used to log when the temperature is above or below a given temperature.
Related Issues/Tickets
How Has This Been Tested?
Screenshots / Recordings (if applicable)
Checklist
Further Notes / Considerations