-
Notifications
You must be signed in to change notification settings - Fork 13
Switch from MallocAllocator to Zephyr k_malloc allocator #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yudataguy
wants to merge
16
commits into
main
Choose a base branch
from
update-malloc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
482341b
Switch from MallocAllocator to Zephyr k_malloc allocator (#313)
yudataguy 764933e
Use ZephyrKmallocAllocator from fprime-zephyr instead of local defini…
yudataguy 5061192
Merge remote-tracking branch 'origin/main' into update-malloc
yudataguy 4ea434f
Update fprime-zephyr submodule to fix MemoryAllocation config registr…
yudataguy 90a1309
Move MemoryAllocation.hpp include to .cpp where concrete type is needed
yudataguy 8cb22f6
Fix MemoryAllocation.hpp include to use config/ prefix
yudataguy 27074e8
Update fprime-zephyr submodule with allocator alignment safety guards
yudataguy 8454df2
Update fprime-zephyr with allocation size rounding fix
yudataguy e0bb64a
Revert kmalloc allocator changes for a fresh approach
yudataguy 48c24d7
Switch ComCcsds to Zephyr k_malloc allocator from fprime-zephyr
yudataguy 6af460c
Update fprime-zephyr submodule with aligned_alloc size rounding fix
yudataguy e210cb3
Update fprime-zephyr to main with merged size-rounding fix (PR #9)
yudataguy 1d34414
Update fprime-zephyr to main with ARM alignment threshold fix (PR #10)
yudataguy a1aeac7
chore: bump fprime-zephyr for allocator fix
yudataguy 0cb03b2
Merge branch 'main' into update-malloc
yudataguy 89b4c30
Merge branch 'main' into update-malloc
Mikefly123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 5 additions & 12 deletions
17
PROVESFlightControllerReference/project/config/ComCcsdsConfig/ComCcsdsSubtopologyConfig.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,10 @@ | ||
| #include "ComCcsdsSubtopologyConfig.hpp" | ||
|
|
||
| namespace ComCcsdsSband { | ||
| namespace Allocation { | ||
| // This instance can be changed to use a different allocator in the ComCcsdsSband Subtopology | ||
| Fw::MallocAllocator mallocatorInstance; | ||
| Fw::MemAllocator& memAllocator = mallocatorInstance; | ||
| } // namespace Allocation | ||
| } // namespace ComCcsdsSband | ||
| #include <default/zephyr-config/ZephyrAllocator.hpp> | ||
|
|
||
| namespace ComCcsdsLora { | ||
| namespace ComCcsds { | ||
| namespace Allocation { | ||
| // This instance can be changed to use a different allocator in the ComCcsdsLora Subtopology | ||
| Fw::MallocAllocator mallocatorInstance; | ||
| Fw::MemAllocator& memAllocator = mallocatorInstance; | ||
| Fw::ZephyrKmallocAllocator allocatorInstance; | ||
| Fw::MemAllocator& memAllocator = allocatorInstance; | ||
| } // namespace Allocation | ||
| } // namespace ComCcsdsLora | ||
| } // namespace ComCcsds |
12 changes: 3 additions & 9 deletions
12
PROVESFlightControllerReference/project/config/ComCcsdsConfig/ComCcsdsSubtopologyConfig.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,12 @@ | ||
| #ifndef COMCCSDSSUBTOPOLOGY_CONFIG_HPP | ||
| #define COMCCSDSSUBTOPOLOGY_CONFIG_HPP | ||
|
|
||
| #include "Fw/Types/MallocAllocator.hpp" | ||
| #include "Fw/Types/MemAllocator.hpp" | ||
|
|
||
| namespace ComCcsdsSband { | ||
| namespace ComCcsds { | ||
| namespace Allocation { | ||
| extern Fw::MemAllocator& memAllocator; | ||
| } | ||
| } // namespace ComCcsdsSband | ||
|
|
||
| namespace ComCcsdsLora { | ||
| namespace Allocation { | ||
| extern Fw::MemAllocator& memAllocator; | ||
| } | ||
| } // namespace ComCcsdsLora | ||
| } // namespace ComCcsds | ||
|
|
||
| #endif |
Submodule fprime-zephyr
updated
6 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.