Simplifications to time dependent source solver. Adding pre-advance and post-advance hooks #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd post-advance hooks.
ragusa
reviewed
Dec 27, 2025
Comment on lines
+156
to
+157
| if (dt < 0.0) | ||
| throw std::runtime_error(GetName() + " dt must be non-negative"); |
Contributor
There was a problem hiding this comment.
can dt be = 0? should we not check for strict positivity?
andrsd
reviewed
Dec 29, 2025
|
|
||
| void PostAdvance(std::function<void()> callback); | ||
|
|
||
| void PostAdvance(std::nullptr_t); |
Collaborator
There was a problem hiding this comment.
Should these 4 setters have Set prefix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pre-advance and post-advance hooks to
TimeDependentSourceSolver::Executeto improve usability of c++ time-stepping method.