Add multiple GPUs support for the Python interface #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quocdang1998
force-pushed
the
python-multi-gpus
branch
2 times, most recently
from
65b92c9 to
d4d927d
Compare
Collaborator
|
A quick comment. This functionality could be useful for testing and/or running on single-user workstations, but really shouldn't be used for production runs on large machines. When there are multiple GPUs on a node, we should leave it up to the job scheduler to associate ranks with GPUs (with the hope that the scheduler does this intelligently and takes CPU/GPU affinity into account). We should probably add a note to that effect in the documentation for these methods. |
quocdang1998
force-pushed
the
python-multi-gpus
branch
from
d4d927d to
54f4131
Compare
andrsd
reviewed
Nov 12, 2025
| shell: bash | ||
| run: | | ||
| module load python3/3.12.3 opensn/gcc/14 doxygen/1.13.2 pandoc/3.6.4 | ||
| export CMAKE_ARGS="-DOPENSN_WITH_CUDA=ON -DCMAKE_CUDA_ARCHITECTURES=89 -DOPENSN_WITH_PYTHON_MODULE=ON" |
Collaborator
There was a problem hiding this comment.
Why is this needed for doco build now?
Will people on machines without nvidia GPU be able to generate doco without this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the GPU selection feature is added to the Python interface, allowing users to launch tests on multiple GPUs when more than one GPU is accessible to an MPI rank.