Adding subtype capabilities to foam_io.cc #813
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitamuraa24
force-pushed
the
updates/Foam2Sn
branch
from
e791d95 to
41de126
Compare
andrsd
approved these changes
Oct 29, 2025
Contributor
Author
|
Dang it, it actually looks like for some cases, its not properly reading boundary cell faces. Was fine with the tests I ran earlier, but I need to look further into this |
Collaborator
|
I marked this as a draft. When you have updates we can convert it into a regular PR again... |
…ad of defaulting to polyhedrons.
kitamuraa24
force-pushed
the
updates/Foam2Sn
branch
from
41de126 to
b01ba6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
' foam_io.cc ' now selects subtypes for cells instead of defaulting to polyhedrons; this should now allow OpenSn to take advantage of uniform cell type meshes and select a preferred sweep method.