Skip to content

Add warning for empty face histogram #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ragusa wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Add warning for empty face histogram #635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions framework/mesh/mesh_continuum/mesh_continuum.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,13 @@ MeshContinuum::MakeGridFaceHistogram(double master_tolerance, double slave_toler

std::stable_sort(face_size_histogram.begin(), face_size_histogram.end());

if (face_size_histogram.empty())
{
log.LogAllWarning() << "MeshContinuum::MakeGridFaceHistogram called on mesh "
"with no faces.";
return std::make_shared<GridFaceHistogram>(face_categories_list);
}

Copy link
Collaborator

@andrsd andrsd Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want the shortcut path for the case when face_size_histogram, you could even move this before the stable_sort...

It would be more correcter :-)

// Determine total face dofs
size_t total_face_dofs_count = 0;
for (auto face_size : face_size_histogram)
Expand Down