using the mss_dir in tests with verification #2983
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This needs first the merge stable to develop |
ReimarBauer
force-pushed
the
another_i2958
branch
from
6c284f7 to
0a502ee
Compare
ReimarBauer
force-pushed
the
another_i2958
branch
from
0a502ee to
596c3a4
Compare
ReimarBauer
commented
Jan 19, 2026
| # REGEX = re.compile(r'(\/.*)|([A-Z]:\\.*)') | ||
| # (mss) | ||
| REGEX = re.compile(r'(~\/.*)|(\/.*)|([A-Z]:\\.*)') | ||
|
|
Member
Author
There was a problem hiding this comment.
without this change the used value gets ignored and the default is then used
ReimarBauer
commented
Jan 19, 2026
| # in conftest we set always the mss_dir in the config file | ||
| # in fixtures we set the mss_dir in the config file | ||
| mss_dir = config_loader(dataset="mss_dir") | ||
| assert "~" not in mss_dir |
Member
Author
There was a problem hiding this comment.
safety check, that the value was changed
ReimarBauer
commented
Jan 19, 2026
|
|
||
| @pytest.fixture | ||
| def msui_configs(tmp_path): | ||
| os.environ['MSUI_SETTINGS'] = os.path.join(tmp_path, "msui_settings.json") |
Member
Author
There was a problem hiding this comment.
msui imports from here
https://github.com/Open-MSS/MSS/blob/develop/mslib/msui/constants.py#L43
The environment variable adds (un?)necessary complexity and could be overlooked.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #2958