Add OpenTelemetry metrics to Commons Pool 2 XA implementation#318
Draft
Add OpenTelemetry metrics to Commons Pool 2 XA implementation#318
Conversation
…tion Co-authored-by: rrobetti <7221783+rrobetti@users.noreply.github.com>
Co-authored-by: rrobetti <7221783+rrobetti@users.noreply.github.com>
Co-authored-by: rrobetti <7221783+rrobetti@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Analyze exposing metrics from OJP XA Apache Commons Pool 2 to OpenTelemetry
Add OpenTelemetry metrics to Commons Pool 2 XA implementation
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes comprehensive pool metrics from the Apache Commons Pool 2 XA connection pool to OpenTelemetry, matching HikariCP's observability capabilities.
Metrics Exposed
Gauges: active/idle/pending connections, max/min pool size, utilization %, created/destroyed counts
Counters: pool exhaustion events, validation failures, leak detections, acquisition time/count
All metrics tagged with
pool.nameattribute for multi-pool environments.Implementation
PoolMetricsinterface - Abstraction layer for metrics collectionOpenTelemetryPoolMetrics- OpenTelemetry integration with 13 metrics via Meter APINoOpPoolMetrics- Zero-overhead implementation when metrics disabledPoolMetricsFactory- Automatic detection and instantiation based on OpenTelemetry availabilityMetricsAwareHousekeepingListener- Wrapper to capture housekeeping events (leak detection) as metricsMetrics update on pool operations (borrow/return/invalidate) and integrate with existing Prometheus exporter in ojp-server.
Configuration
Design Notes
providedscope - no hard dependencyExample Prometheus output:
See
METRICS.mdfor complete reference, monitoring best practices, and alerting recommendations.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.