Skip to content

make the ojp-server docker image leaner#316

Open
matheusandre1 wants to merge 1 commit intoOpen-J-Proxy:mainfrom
matheusandre1:issue49
Open

make the ojp-server docker image leaner#316
matheusandre1 wants to merge 1 commit intoOpen-J-Proxy:mainfrom
matheusandre1:issue49

Conversation

@matheusandre1
Copy link
Contributor

Closes #49 , This reduces it, but is that all there is to it?

@rrobetti
Copy link
Contributor

@matheusandre1 have you run the integration tests against the new image? Would be great if you could run all integration tests against the old image and then against the new one to compare.

@matheusandre1
Copy link
Contributor Author

matheusandre1 commented Jan 30, 2026

eclipse-temurin:22-jre (Standard): 494.67 MB
eclipse-temurin:22-jre-alpine (Alpine): 360.5 MB

@matheusandre1
Copy link
Contributor Author

image

@rrobetti
Copy link
Contributor

rrobetti commented Feb 1, 2026

@matheusandre1 have you run the integration tests against the docker image? Currently, in the CI workflow we don't run tests against the docker image, we run OJP Server as an executable JAR. That is why I am insisting on testing it locally.

@matheusandre1
Copy link
Contributor Author

Yes, I rotated and built an image on top.

@matheusandre1
Copy link
Contributor Author

image

@rrobetti
Copy link
Contributor

rrobetti commented Feb 2, 2026

image

@matheusandre1 , the integration tests I'm referring to are the ones that are in ojp-jdbc and run against the real databases. there's a video explaining it here: https://youtu.be/KFR-DGmc2A0?si=wxZe-PcK5QP0wjoM

@matheusandre1
Copy link
Contributor Author

I'll check it out, thanks for reminding me about that, I believe the CI is costly for you.

@rrobetti
Copy link
Contributor

rrobetti commented Feb 3, 2026

I'll check it out, thanks for reminding me about that, I believe the CI is costly for you.

@matheusandre1 it's not about the cost, it is that the CI does not use docker images, it runs an executable JAR only at the moment.

@matheusandre1
Copy link
Contributor Author

matheusandre1 commented Feb 3, 2026

I'll do that tonight, I'm having trouble testing it, I'm using ACT and it's gotten worse lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make the ojp-server docker image leaner

2 participants