Enhancement/implement xa support for db2 database#154
Enhancement/implement xa support for db2 database#154ignorant05 wants to merge 3 commits intoOpen-J-Proxy:mainfrom
Conversation
|
@ignorant05 DB2 integration tests should be disabled by default as per it is a proprietary database. |
|
Sorry, i forgot about that. this should be fine now. |
|
|
||
| @BeforeAll | ||
| public static void setup() { | ||
| isTestDisabled = !Boolean.parseBoolean(System.getProperty("enableMariaDBTests", "false")); |
There was a problem hiding this comment.
@ignorant05 MariaDB tests should be enabled by default and run with the main CI pipeline as per Maria DB is open source and we can pack with the jdbc driver without restrictions.
| @@ -0,0 +1 @@ | |||
| org.openjproxy.jdbc.Driver,jdbc:ojp[localhost:1059]_mariadb://localhost:50000/testmariadb,db2inst1,testpass | |||
There was a problem hiding this comment.
MariadDB runs on port 3307 for tests on the main CI workflow, not on 50000. Please test any changes before submitting a PR.
| @@ -0,0 +1 @@ | |||
| org.openjproxy.jdbc.Driver,jdbc:ojp[localhost:1059]_mariadb://localhost:50000/testmariadb,db2inst1,testpass | |||
There was a problem hiding this comment.
@ignorant05 Some documentation of MariaDB suggests that to work with XA it needs to use mysql url standard (lets remember that MariaDB is a fork of MySQL), so your URL might look like this in the end:
org.openjproxy.jdbc.Driver,jdbc:ojp[localhost:1059]_mysql://localhost:3307/testmariadb,testuser,testpassword
But please test locally before submitting.
| * 3. The client-side code updated to use integrated StatementService | ||
| */ | ||
| @Slf4j | ||
| public class DB2XAIntegrationTest { |
There was a problem hiding this comment.
@ignorant05 these tests are not passing locally, please refer to https://github.com/Open-J-Proxy/ojp/blob/main/documents/environment-setup/db2-testing-guide.md and test them before submitting the PR.
2 participants
Solves #73