Skip to content

Fixed Pylint Issues #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andewmark merged 1 commit into from
Feb 2, 2025
Merged

Fixed Pylint Issues #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions tests/weather_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
This module contains unit tests for the 'weather.py' module, which handles
weather data fetching and extraction functionality
"""

#pylint: disable=E0401
import unittest
from unittest.mock import patch, Mock
import requests
Expand All @@ -15,6 +15,7 @@ class TestFetchWeatherForecast(unittest.TestCase):

def setUp(self):
""" Sample mock API response """
#pylint: disable=C0301
self.mock_response = {
"properties": {
"periods": [
Expand All @@ -27,7 +28,7 @@ def setUp(self):
]
}
}

@patch("requests.get")
def test_successful_api_call(self, mock_get):
"""
Expand All @@ -37,7 +38,7 @@ def test_successful_api_call(self, mock_get):
mock_response.json.return_value = self.mock_response
mock_response.status_code = 200
mock_get.return_value = mock_response

result = fetch_weather_forecast()

self.assertIsNotNone(result)
Expand All @@ -55,7 +56,7 @@ def test_api_connection_error(self, mock_get):
result = fetch_weather_forecast()

self.assertIsNone(result)

@patch("requests.get")
def test_api_404_error(self, mock_get):
"""
Expand All @@ -71,17 +72,18 @@ def test_api_404_error(self, mock_get):
result = fetch_weather_forecast()

self.assertIsNone(result)

@patch("requests.get")
def test_api_500_error(self, mock_get):
"""
Test when the API return a 500 Server Error
"""
#pylint: disable=C0301
mock_response = Mock()
mock_response.status_code = 500
mock_response.raise_for_status.side_effect = requests.exceptions.HTTPError("500 Internal Server Error")
mock_get.return_value = mock_response

result = fetch_weather_forecast()

self.assertIsNone(result)
self.assertIsNone(result)
Loading