Seperate speed and distance message classes into their own files #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SpeedMessagesInterface was very large. This helps to scope down each message to its own file, which hopefully makes it easier to add new messages and maintain old ones.
ad3154
force-pushed
the
adrian/j1939_speed
branch
from
dd89d74 to
0d321a6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
SpeedMessagesInterfacewas very large. This helps to scope down each message to its own file while maintaining the same actual interface for theSpeedMessagesInterface, which hopefully makes it easier to add new messages and maintain old ones.