Merged
Conversation
ospfranco
requested changes
Oct 31, 2025
| } | ||
|
|
||
| - (void)viewDidDisappear:(BOOL)animated { | ||
| [super viewDidDisappear:animated]; |
Collaborator
There was a problem hiding this comment.
Can you undo the formatting changes? What did you use to format these files?
Collaborator
Author
There was a problem hiding this comment.
ok undid them manually, but i used xcodes formatting (Cmd+A + Ctrl+I) with everything default, it did 4 spaces as indents when it looks like your (everyone?) using 2, and even when i change it to 2 other stuff what mismatching.
Collaborator
There was a problem hiding this comment.
Xcode formatting is not good because it's xcode only, no other tool replicates it properly. I think me and the rest we are using vscode formatting with clang-format and swift-format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.