Open
Conversation
…Flow-Benchmark into dev_sx_benchmark
ShawnXuan
requested changes
Aug 13, 2020
Collaborator
ShawnXuan
left a comment
ShawnXuan
left a comment
There was a problem hiding this comment.
目录名字暂时不能改，1. oneflow-document文档里有引用的地方；2. 现在的目录名字也是之前讨论过的
涉及的文件太多了，建议修改后再pr。
| help='nodes ip list for training, devided by ",", length >= num_nodes') | ||
|
|
||
| parser.add_argument("--model", type=str, default="resnet50", | ||
| parser.add_argument("--model", type=str, default="resnext50", |
nlqq
commented
Aug 18, 2020
Contributor
Author
nlqq
left a comment
nlqq
left a comment
There was a problem hiding this comment.
目录名字暂时不能改，1. oneflow-document文档里有引用的地方；2. 现在的目录名字也是之前讨论过的
涉及的文件太多了，建议修改后再pr。
目录名字可以根据情况更新，也可以再次讨论，引用的地方我来一起改掉。
这些文件多半是由于改名带来的变动，但总体是一次修改，需要分多次pr吗？
| help='nodes ip list for training, devided by ",", length >= num_nodes') | ||
|
|
||
| parser.add_argument("--model", type=str, default="resnet50", | ||
| parser.add_argument("--model", type=str, default="resnext50", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refrom the structure of benchmark