-
Notifications
You must be signed in to change notification settings - Fork 461
fix: restore OneKey ID and Prime in webdapp more menu #9517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughConditional rendering logic based on platform environment (isWebDappMode, platformWebDappMode) has been removed from MoreActionButton. Prime action, UpdateReminders, and MoreActionOneKeyId components now render consistently across all platforms rather than being conditionally excluded. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting Disabled knowledge base sources:
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (4)
Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Pull request was converted to draft
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.
These features were previously hidden in commit 02c3b86 for webdapp mode and are now restored.
Changes
platformEnv.isWebDappModecondition forMoreActionOneKeyIdcomponent inBaseMoreActionContentandMoreActionContent!platformEnv.isWebDappModecondition for Prime menu item inMoreActionGeneralGridTest plan