Skip to content

Conversation

@uhakruthi1
Copy link
Contributor

Description

Screenshot 2026-01-17 at 8 26 44 PM

Related PRS (if any):

https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/pull/4279/files

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to http://localhost:5173/bmdashboard/totalconstructionsummary
  6. verify dark mode styling

Screenshots or videos of changes:

Screenshot 2026-01-17 at 8 17 26 PM Screenshot 2026-01-17 at 8 17 36 PM

Note:

Include the information the reviewers need to know.

@netlify
Copy link

netlify bot commented Jan 18, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 4821b9f
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69743861e0d6d800089c12cd
😎 Deploy Preview https://deploy-preview-4732--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@uhakruthi1 uhakruthi1 changed the title Fix UI visibility 4279 uha fix ui visibility labour hour chart Jan 18, 2026
@uhakruthi1 uhakruthi1 force-pushed the fix-ui-visibility-4279 branch 2 times, most recently from 365f86d to 8b56618 Compare January 18, 2026 01:54
Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Uha,

I have reviewed your PR locally, though most of the functionality is well adapted to dark mode. The issues i found are:

  • The calendar in Distribution of Labor Hours is still very much in Light mode.
  • Similarly the Custom Dates option in Paid Labor Cost appears broken.
  • Also both the heading are in different text color, i suppose both should be in Blue.
  • And the submit button does not work in Distribution of Labor Hours which i assume could be out of scope for you.
Screenshot 2026-01-21 at 10 53 49 PM Screenshot 2026-01-21 at 10 54 20 PM Screenshot 2026-01-21 at 10 54 35 PM **Issue related images** Screenshot 2026-01-21 at 10 55 00 PM Screenshot 2026-01-21 at 10 55 11 PM Screenshot 2026-01-21 at 10 55 42 PM

@uhakruthi1 uhakruthi1 force-pushed the fix-ui-visibility-4279 branch 2 times, most recently from 6d4265d to 3b62832 Compare January 24, 2026 02:29
@sonarqubecloud
Copy link

@uhakruthi1
Copy link
Contributor Author

Hi Uha,

I have reviewed your PR locally, though most of the functionality is well adapted to dark mode. The issues i found are:

  • The calendar in Distribution of Labor Hours is still very much in Light mode.
  • Similarly the Custom Dates option in Paid Labor Cost appears broken.
  • Also both the heading are in different text color, i suppose both should be in Blue.
  • And the submit button does not work in Distribution of Labor Hours which i assume could be out of scope for you.

Screenshot 2026-01-21 at 10 53 49 PM Screenshot 2026-01-21 at 10 54 20 PM Screenshot 2026-01-21 at 10 54 35 PM Issue related images Screenshot 2026-01-21 at 10 55 00 PM Screenshot 2026-01-21 at 10 55 11 PM Screenshot 2026-01-21 at 10 55 42 PM

Hi Anusha, Thank you for reviewing the PR and for the detailed feedback.
My task scope was limited to Distribution of Labor Hours, so I did not make changes related to Paid Labor Cost. The calendar issue in Distribution of Labor Hours has been fixed as part of this PR.
The remaining points (Custom Dates in Paid Labor Cost, heading color inconsistency, and the submit button issue) are currently outside the scope of this task. If needed, I can address them in a separate task.

Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Uha,

Thanks for the update and appreciate the fix for the calendar issue. Please do address the other issues to the concerned people who take care of the document that has this PR, if these do not exist already. Mainly the submit issue since without that we cannot verify if the options selected even work.
Screenshot 2026-01-24 at 12 22 55 AM

Copy link

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Uha,

Well done with this implementation.

Issues:
Project Status is not accurate.
Paid Labor Cost - White dropboxes.

PR 4732 Screenshot PR 4732 Screenshot 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants