-
-
Notifications
You must be signed in to change notification settings - Fork 72
uha fix ui visibility labour hour chart #4732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
365f86d to
8b56618
Compare
Anusha-Gali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Uha,
I have reviewed your PR locally, though most of the functionality is well adapted to dark mode. The issues i found are:
- The calendar in Distribution of Labor Hours is still very much in Light mode.
- Similarly the Custom Dates option in Paid Labor Cost appears broken.
- Also both the heading are in different text color, i suppose both should be in Blue.
- And the submit button does not work in Distribution of Labor Hours which i assume could be out of scope for you.
**Issue related images**
6d4265d to
3b62832
Compare
|
Hi Anusha, Thank you for reviewing the PR and for the detailed feedback. |
Anusha-Gali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Uha,
Thanks for the update and appreciate the fix for the calendar issue. Please do address the other issues to the concerned people who take care of the document that has this PR, if these do not exist already. Mainly the submit issue since without that we cannot verify if the options selected even work.

rohanrastogi311
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.











Description
Related PRS (if any):
https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/pull/4279/files
How to test:
Screenshots or videos of changes:
Note:
Include the information the reviewers need to know.