-
Notifications
You must be signed in to change notification settings - Fork 8
Enhanced i18n workflow and fixed duplicate translation string error #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added msgctxt to fix duplicate string error for "species" (singular, plural) - Edited metadata - Removed legacy translation strings - Added translations for the new entries
- Fixed and enhanced debug mode check
- Added Docker configuration for translations and troubleshooting steps
dr-rompecabezas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juanpac96 and @Cheva998
I appreciate your help reviewing the translations I added.
Thanks.
| # Urban Tree Observatory | ||
| # Copyright (C) 2025 Legut | ||
| # This file is distributed under the same license as the Urban Tree Observatory package. | ||
| # Sebastián Duque <sduquet998@gmail.com>, 2025. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juanpac96 please review the legal metadata here.
@Cheva998 you're credited differently in the 'en' and 'es' files. In one you have the email address and the other you don't. Let me know your preference, or edit it yourself.
| #: apps/places/models.py:15 | ||
| #: apps/places/models/spatial.py:13 | ||
| msgid "country boundary" | ||
| msgstr "límites del país" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I consistently translated "boundary" as "límites".
For context, this refers to the field that holds the MultiPolygon geography.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the internationalization workflow by fixing duplicate translation string errors and improving translation processes.
- Fixed duplicate translation string error by adding context for singular and plural forms.
- Updated the Docker entrypoint script and the CI workflow to include translation message compilation.
- Improved documentation for translation extraction, compilation, and troubleshooting.
Reviewed Changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/i18n-strategy-guide.md | Added Docker configuration, detailed translation workflow instructions, and troubleshooting tips. |
| .github/workflows/ci.yml | Integrated translation message compilation into the CI workflow. |
Files not reviewed (3)
- backend/docker-entrypoint.sh: Language not supported
- backend/locale/en/LC_MESSAGES/django.po: Language not supported
- backend/locale/es/LC_MESSAGES/django.po: Language not supported
juanpac96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is ready to be merged. I approve it.
This PR enhances our internationalization workflow and fixes an error.
msgctxt "singular"andmsgctxt "plural".compilemessagesto Docker's entrypoint shell script to ensure translations are always compiled.compilemessagesto CI to enhance our workflow.