Skip to content

Fix claude config#125

Merged
Okabe-Junya merged 1 commit intomainfrom
fix-claude-config
Dec 5, 2025
Merged

Fix claude config#125
Okabe-Junya merged 1 commit intomainfrom
fix-claude-config

Conversation

@Okabe-Junya
Copy link
Copy Markdown
Owner

This pull request mainly updates configuration and setup for the Claude tool, focusing on improving permissions management, environment setup, and installation reliability. The most significant changes are in .config/claude/settings.json, where permissions and environment variables are restructured, and in the installation script, which now ensures directories exist before creating symlinks.

Claude configuration changes:

  • Moved environment variables (env) and cleanup settings (cleanupPeriodDays) to the top level of .config/claude/settings.json, simplifying configuration management.
  • Refactored permissions by moving the deny list higher in the permissions block for clarity and maintainability, without changing the actual denied permissions.
  • Modified sandbox settings: disabled sandboxing by default and removed granular sandbox configuration options, streamlining the configuration.
  • Added new configuration options: enableAllProjectMcpServers, forceLoginMethod, and outputStyle, enhancing integration and output customization.

Installation script improvements:

  • Updated install/symlink.zsh to create the .config/claude directory if it doesn't exist before creating symlinks, preventing installation errors. Also added a symlink for statusline.sh.

@Okabe-Junya Okabe-Junya requested a review from Copilot December 5, 2025 18:47
@Okabe-Junya Okabe-Junya self-assigned this Dec 5, 2025
@Okabe-Junya Okabe-Junya merged commit dc5f00b into main Dec 5, 2025
8 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-claude-config branch December 5, 2025 18:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Claude CLI tool configuration by correcting the configuration directory path from ~/.claude/ to ~/.config/claude/ (following XDG Base Directory specification) and restructuring the settings for better organization and maintainability.

Key changes:

  • Corrected configuration directory path from ~/.claude/ to ~/.config/claude/ in the installation script
  • Restructured settings.json by moving environment variables and cleanup settings to the top level for clarity
  • Simplified sandbox configuration by disabling it and removing granular options, while maintaining security through the comprehensive permissions deny list

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
install/symlink.zsh Fixed symlink target path from ~/.claude/ to ~/.config/claude/, added directory creation check, and added symlink for statusline.sh
.config/claude/settings.json Reorganized configuration structure by moving env and cleanupPeriodDays to top level, reordered permissions blocks for clarity, simplified sandbox settings, and added new configuration options (enableAllProjectMcpServers, forceLoginMethod, outputStyle)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,5 +1,13 @@
{
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "model" field (previously set to "claude-sonnet-4-5-20250929") has been removed from the configuration. If the Claude tool requires a model specification to function correctly, this could cause runtime errors or unexpected behavior. Please verify if the model field is still needed or if the tool now uses a default model.

Suggested change
{
{
"model": "claude-sonnet-4-5-20250929",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants