Skip to content

Enable fbset in Nerves rootfs for LCD framebuffer validation#62

Open
vmanchala-dev wants to merge 1 commit intocomcard_v2_cifrom
vj/fbset_tools
Open

Enable fbset in Nerves rootfs for LCD framebuffer validation#62
vmanchala-dev wants to merge 1 commit intocomcard_v2_cifrom
vj/fbset_tools

Conversation

@vmanchala-dev
Copy link

@vmanchala-dev vmanchala-dev commented Jan 30, 2026

Description

Enabled the fbset framebuffer utility in the Nerves system root filesystem to support LCD and framebuffer validation.

Details

  • The SPI LCD (ILI9488) driver creates /dev/fb0 successfully.
  • To verify framebuffer geometry, pixel format, and timing, the fbset utility is required.
  • fbset is available in the current Buildroot version and has been enabled via:
    • Config.in (to expose the package)
    • nerves_defconfig (to select the package)

Notes:

The fbi framebuffer image viewer is not available in the Buildroot version used by this system and therefore cannot be included.

Test logs

System.cmd("fbset", ["-i"])
{"\nmode \"320x480\"\n    geometry 320 480 320 480 16\n    timings 0 0 0 0 0 0 0\n    accel true\n    rgba 5/11,6/5,5/0,0/0\nendmode\n\nFrame buffer device information:\n    Name        : ili9488drmfb\n ,
 0}


Note

Low Risk
Low risk: this only tweaks Buildroot configuration to include additional userland tools in the rootfs, with no changes to runtime logic or security-sensitive code paths.

Overview
Adds a new Buildroot Framebuffer debug tools menu (package/tools/Config.in) and wires it into the top-level Config.in.

Updates nerves_defconfig to include framebuffer validation utilities (fbset, fbi) and their image format dependencies (jpeg, png) in the built root filesystem.

Written by Cursor Bugbot for commit f39436d. This will update automatically on new commits. Configure here.

@vmanchala-dev vmanchala-dev requested a review from vs-pp January 30, 2026 12:01
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

BR2_PACKAGE_EXTRA_DTS=y
BR2_PACKAGE_BBORG_OVERLAYS_ZOLA=y
BR2_PACKAGE_FBSET=y
BR2_PACKAGE_FBI=y
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FBI package enabled despite being documented as unavailable

High Severity

The PR description explicitly states that "fbi framebuffer image viewer is not available in the Buildroot version used by this system and therefore cannot be included." However, the code adds BR2_PACKAGE_FBI=y in nerves_defconfig and includes a config entry in package/tools/Config.in. This contradiction will likely cause a build failure when Buildroot tries to build a package that doesn't exist in this version.

Additional Locations (1)

Fix in Cursor Fix in Web

config BR2_PACKAGE_FBSET
bool "fbset (framebuffer settings utility)"
help
Utility to show and change Linux framebuffer settings.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config.in redefines existing Buildroot package symbol for fbset

High Severity

The package/tools/Config.in defines config BR2_PACKAGE_FBSET, but fbset is an existing Buildroot package that already has this symbol defined in Buildroot's own package/fbset/Config.in. This duplicate Kconfig symbol definition will cause a configuration error when Buildroot processes both Config.in files. To enable an existing Buildroot package, only the defconfig entry BR2_PACKAGE_FBSET=y is needed - the custom Config.in entry is unnecessary and harmful.

Fix in Cursor Fix in Web

@vs-pp
Copy link

vs-pp commented Jan 30, 2026

@vmanchala-dev Have you addressed the cursorbot review comments? Please add comments as you fix them, so that we know they are addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants