Enable fbset in Nerves rootfs for LCD framebuffer validation#62
Enable fbset in Nerves rootfs for LCD framebuffer validation#62vmanchala-dev wants to merge 1 commit intocomcard_v2_cifrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| BR2_PACKAGE_EXTRA_DTS=y | ||
| BR2_PACKAGE_BBORG_OVERLAYS_ZOLA=y | ||
| BR2_PACKAGE_FBSET=y | ||
| BR2_PACKAGE_FBI=y |
There was a problem hiding this comment.
FBI package enabled despite being documented as unavailable
High Severity
The PR description explicitly states that "fbi framebuffer image viewer is not available in the Buildroot version used by this system and therefore cannot be included." However, the code adds BR2_PACKAGE_FBI=y in nerves_defconfig and includes a config entry in package/tools/Config.in. This contradiction will likely cause a build failure when Buildroot tries to build a package that doesn't exist in this version.
Additional Locations (1)
| config BR2_PACKAGE_FBSET | ||
| bool "fbset (framebuffer settings utility)" | ||
| help | ||
| Utility to show and change Linux framebuffer settings. |
There was a problem hiding this comment.
Config.in redefines existing Buildroot package symbol for fbset
High Severity
The package/tools/Config.in defines config BR2_PACKAGE_FBSET, but fbset is an existing Buildroot package that already has this symbol defined in Buildroot's own package/fbset/Config.in. This duplicate Kconfig symbol definition will cause a configuration error when Buildroot processes both Config.in files. To enable an existing Buildroot package, only the defconfig entry BR2_PACKAGE_FBSET=y is needed - the custom Config.in entry is unnecessary and harmful.
|
@vmanchala-dev Have you addressed the cursorbot review comments? Please add comments as you fix them, so that we know they are addressed. |


Description
Enabled the fbset framebuffer utility in the Nerves system root filesystem to support LCD and framebuffer validation.
Details
Notes:
The fbi framebuffer image viewer is not available in the Buildroot version used by this system and therefore cannot be included.
Test logs
Note
Low Risk
Low risk: this only tweaks Buildroot configuration to include additional userland tools in the rootfs, with no changes to runtime logic or security-sensitive code paths.
Overview
Adds a new Buildroot
Framebuffer debug toolsmenu (package/tools/Config.in) and wires it into the top-levelConfig.in.Updates
nerves_defconfigto include framebuffer validation utilities (fbset,fbi) and their image format dependencies (jpeg,png) in the built root filesystem.Written by Cursor Bugbot for commit f39436d. This will update automatically on new commits. Configure here.