Disable base SPI channel nodes for LCD and touch#61
Open
vmanchala-dev wants to merge 3 commits intocomcard_v2_cifrom
Open
Disable base SPI channel nodes for LCD and touch#61vmanchala-dev wants to merge 3 commits intocomcard_v2_cifrom
vmanchala-dev wants to merge 3 commits intocomcard_v2_cifrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| __overlay__ { | ||
| status = "disabled"; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Inconsistent indentation uses tabs instead of spaces
Low Severity
The new fragment@3 through fragment@6 (lines 103-135) use tab characters for indentation, while the rest of the file consistently uses 4-space indentation. This creates visual inconsistency and can cause confusing diffs when different editors auto-format the file differently. The file mixes two indentation styles in directly adjacent code blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
When custom SPI devices (ILI9488 LCD and ADS7846 touch) are added via overlay, these default nodes causing below errors
We are explicitly sets status = "disabled" on the base SPI channel@* nodes using target-path.
This prevents the placeholder SPI devices from being created while keeping the SPI controllers enabled for custom drivers.
Test
After loading the driver on V2 following is the message
With these changes we will do actual test on reworked board and verify.
Note
Medium Risk
Medium risk because it changes device-tree SPI topology/pinmux for both McSPI0 and McSPI1 and can break SPI peripherals or pin assignments if target paths or GPIO mappings are wrong.
Overview
Prevents SPI chip-select conflicts for the LCD+touch overlay. The overlay now explicitly disables the base AM335x
channel@0/channel@1SPI child nodes (for both McSPI0 and McSPI1) viatarget-path, instead of deleting nodes under&spi1, so customili9488andads7846devices can bind cleanly.Also updates pin/pinmux handling: disables an additional pinmux (
P8_41_pinmux), changes the LCD reset pinmux andreset-gpiosmapping to a new GPIO, and bumpsVERSIONto2.27.2+zola-12k.Written by Cursor Bugbot for commit e0c4d4e. This will update automatically on new commits. Configure here.