Skip to content

Conversation

@amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Jul 18, 2025

Fixes: NIT-3523
Pulls in OffchainLabs/bold#753

ProcessAllAssertionsInRange is called in two scenarios:

  1. During startup — when the system processes from the last confirmed assertion to the latest block.

    • This case was already handled by splitting the getLogs query into smaller batch FilterOpts to avoid exceeding the block limit.
  2. During regular polling — when the system polls at a configured interval.

    • The assumption was that regular polling would naturally limit the batch size. However, since the polling interval is configurable, the block range could still exceed the limit.

This PR ensures that even during the polling flow, getLogs queries are broken down into smaller batch FilterOpts, preventing potential block limit issues in both scenarios.

tsahee
tsahee previously approved these changes Jul 23, 2025
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee enabled auto-merge July 23, 2025 18:17
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee merged commit 90100c5 into master Jul 23, 2025
18 checks passed
@tsahee tsahee deleted the getlogs_small_chunks branch July 23, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants