Skip to content

Var to install R from CRAN or from the distribution packages#42

Draft
jmaspons wants to merge 1 commit intoOefenweb:masterfrom
jmaspons:noCRAN
Draft

Var to install R from CRAN or from the distribution packages#42
jmaspons wants to merge 1 commit intoOefenweb:masterfrom
jmaspons:noCRAN

Conversation

@jmaspons
Copy link

No description provided.

@tersmitten tersmitten modified the milestones: 2.1, 2.1.0 Feb 27, 2020
@tersmitten
Copy link
Member

I'm open to the idea. Can you fix the build issues?

---
- include: repository.yml
when:
- r_cran_repo == true
Copy link
Contributor

@FanchTheSystem FanchTheSystem Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove the '== true' on this line to have it build on travis ci
Something like :

- include: repository.yml
  when:
    - r_cran_repo

As it is a boolean

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Or maybe r_cran_repo | bool just to be safe

@tersmitten tersmitten marked this pull request as draft January 20, 2021 09:46
@tersmitten
Copy link
Member

I'm not sure this change will work (without more adjustments). Can you have a look at the usage of r_version? Some behavior is dependent on that variable which is probably wrong when using r_cran_repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants