Skip to content

[NEW]jose_manuel_pizarro_interview:Modulo de lista de supermercado#5

Closed
JoseMPP wants to merge 5 commits intoOdoo-Concept:18.0from
JoseMPP:jose_manuel_pizarro_interview_branch
Closed

[NEW]jose_manuel_pizarro_interview:Modulo de lista de supermercado#5
JoseMPP wants to merge 5 commits intoOdoo-Concept:18.0from
JoseMPP:jose_manuel_pizarro_interview_branch

Conversation

@JoseMPP
Copy link

@JoseMPP JoseMPP commented Jul 31, 2025

Modulo Lista de Supermercado creado por Jose Manuel Pizarro como prueba para Backend Developer.
Features adicionales:
-Unidad de medida por item, que a mi parecer puede ser muy util en una lista de materiales.
-Restriccion para que de un item sólo se pueda editar el campo Comprado si su estado es En Progreso.

Aclaración: La traducción en español esta para español de Bolivia.

Saludos!!

Copy link
Contributor

@OC-ebirbe OC-ebirbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @JoseMPP

Thank you for your interest to participate with us.

Could you check the errors reported in this PR and fix it please?

You can use the command to help you:

`pre-commit run --all-files`

@OC-ebirbe
Copy link
Contributor

Hello @JoseMPP are you still working on this?

There are still errors in the automated review checks.

Let me know when it's fixed and ready for the technical review.

@JoseMPP
Copy link
Author

JoseMPP commented Aug 1, 2025

Hello @OC-ebirbe , I had some issues with my local environment when trying to run pre-commit, but I’ve already fixed the errors that were showing up in the GitHub Actions.

@JoseMPP
Copy link
Author

JoseMPP commented Aug 1, 2025

Hello @OC-ebirbe . I just check the error in the pre-commit job and the only error it's related to ruff-format.I tried to run the ruff check locally and using the config file but it doesn't show any error. Do you know what the problem could be?
Capture

Capture

@OC-ebirbe
Copy link
Contributor

Do you know what the problem could be?

There may be discrepancies between the raw call to the ruff command vs calling it inside the context of the pre-commit settings with pre-commit run --all-files.

There is probably missing steps or parameters, in your manual calls.

@JoseMPP
Copy link
Author

JoseMPP commented Aug 4, 2025

Hello @OC-ebirbe , I was using ruff check for linting but in the pre-commit job it uses it to format, that was my mistake and I fixed it in my last commit.

@OC-ebirbe
Copy link
Contributor

Nice @JoseMPP

Thanks.

@OC-ebirbe OC-ebirbe closed this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants