feat: enable space default runbook retention #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rose-Northey
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enables support for Runbook retention policies as part of the Space Default Retention Policy feature. The changes add the ability to configure and manage runbook retention settings alongside existing lifecycle retention policies.
Key Changes
- Added
RunbookRetentionTypeconstant to support runbook retention policy type - Implemented
RunbookRetentionPolicystruct with count-based and keep-forever retention strategies - Added comprehensive end-to-end tests covering read and modify operations for runbook retention policies
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pkg/retention/retention_policy.go |
Added RunbookRetentionType constant following existing naming patterns |
pkg/retention/space_default_runbook_retention_policy.go |
Introduced new runbook retention policy struct and constructor functions matching the established pattern for lifecycle policies |
test/e2e/space_default_retention_policy_service_test.go |
Added three test cases for runbook retention: read, count-based modification, and forever-based modification; also standardized import ordering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
octopus-hideaki
approved these changes
Dec 1, 2025
Contributor
octopus-hideaki
left a comment
octopus-hideaki
left a comment
There was a problem hiding this comment.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables the Space Default Retention Policy to be set for Runbook retention.
[sc-126262]