feat: Add Ephemeral Environment Deprovisioning #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevencl840
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for deprovisioning ephemeral environments in the Go SDK. The implementation introduces a new Deprovision function that triggers runbook runs to clean up ephemeral environments, along with comprehensive test coverage.
- Adds a new
DeprovisionAPI method to the ephemeral environments service - Introduces data structures for deprovisioning commands, responses, and runbook runs
- Adds comprehensive end-to-end tests including deferred cleanup in existing tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/environments/v2/route.go | Adds the API route template for deprovisioning ephemeral environments |
| pkg/environments/v2/ephemeralenvironments/ephemeral_environment_service.go | Implements the Deprovision function and related data structures for deprovisioning ephemeral environments |
| test/e2e/ephemeral_environment_service_test.go | Adds deferred cleanup using DeprovisionEphemeralEnvironment and new test case for the deprovision functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkg/environments/v2/ephemeralenvironments/ephemeral_environment_service.go
Outdated
Show resolved
Hide resolved
pkg/environments/v2/ephemeralenvironments/ephemeral_environment_service.go
Outdated
Show resolved
Hide resolved
dylanlerch
approved these changes
Nov 3, 2025
stevencl840
force-pushed
the
sjc/add-ee-deprovisioning
branch
from
8208e80 to
9e58c8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context 🌆
Ephemeral environments are temporary environments that developers can use to test changes. They are expected to come and go with the same cadence as a PR, created when the PR is opened and torn down when it is merged.
Users would like to be able to manually deploy their release to their ephemeral environment rather than having it deployed automatically when the release is created.
Details 🔍
This PR adds the ability to deprovision an ephemeral environment to the Go API client. I have added a test to demonstrate it working, and have updated the create ephemeral environment test to use deprovisioning to clean up after itself.
[sc-124429]