Add progress logging to await task #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mik-ky
approved these changes
Apr 3, 2025
mik-ky
left a comment
mik-ky
left a comment
There was a problem hiding this comment.
Changes make sense to me - haven't tested it out myself for obvious reasons, though 😄
|
|
||
| await waiter.waitForServerTasksToComplete(taskIds, inputParameters.pollingInterval * 1000, inputParameters.timeout * 1000, (t) => { | ||
| const taskResult = lookup.get(t.Id); | ||
| if (!taskResult) return; |
| timeoutSeconds = +timeoutField; | ||
| } | ||
|
|
||
| const showProgress = task.getBoolean("ShowProgress") ?? false; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
OctopusDeployReleaseV5 allowed for the progress of the deployment to be shown. SinceOctopusDeployReleaseV6, the waiting for the deployment task to finish has been moved to theOctopusAwaitTask. However, this task is currently missing an option to show the progress of the deployment.Results
Adds a new optional
ShowProgressflag toOctopusAwaitTaskV6.Fixes #342
[sc-104339]
Before
After
Testing
This was tested on Azure DevOps Server 2022 and Azure DevOps Server 2019.
Note that V6 Tasks are only supported on Azure DevOps Server 2019+
Functionality Tested:
Scenarios Tested:
ShowProgressflag on/off