Support escaped colon in variables #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuyPhanNguyen
requested review from
IsaacCalligeros95,
benPearce1 and
grace-rehn
IsaacCalligeros95
approved these changes
Jan 6, 2025
Contributor
IsaacCalligeros95
left a comment
IsaacCalligeros95
left a comment
There was a problem hiding this comment.
LGTM, I can't think of any common use cases of \: it'd be good to get a second opinion on that though.
HuyPhanNguyen
deleted the
huy/2025/1/support-escaped-colon-in-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to sc-100335
Support escaped colons in variable names
Fixed issue where variables containing colons in their names (e.g., "Test:Variable") were being incorrectly split. Added support for escaped colons using backslash (e.g.,
Test\:Variable) to allow colons as part of variable names while maintaining the existing delimiter functionality.Example usage: