Open
Conversation
OctaFloare
reviewed
Jul 12, 2024
| const response = await axios.post('/api/movies', {id: 7, name: "Dune" }) | ||
|
|
||
| const createMovie = async (values) => { | ||
| console.log(values) |
Owner
There was a problem hiding this comment.
We should remove this console log
OctaFloare
reviewed
Jul 12, 2024
| const nameParts = name.split('.'); | ||
|
|
||
| let transformedName = nameParts[1] != undefined?`${nameParts[0]}[${nameParts[1]}].${nameParts[2]}`:`${nameParts[0]}`; | ||
| if(nameParts[0] == "crew"){ |
Owner
There was a problem hiding this comment.
Instead of edge casing a component that can be reusable to handle "crew", we could leave the FormField as a template and create a CrewFormField that would handle the transformed name for the crew. Also, why do we need such a long name for the input name?
OctaFloare
reviewed
Jul 12, 2024
Owner
OctaFloare
left a comment
OctaFloare
left a comment
There was a problem hiding this comment.
Nice work adding validation, extracting components, handling errors. Awesome job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.