Open
Conversation
added 6 commits
July 11, 2024 12:04
OctaFloare
reviewed
Jul 12, 2024
| </div> | ||
| )} | ||
|
|
||
| <Field |
Owner
There was a problem hiding this comment.
Since all these fields are repetitive, we could extract into a separate component that could be reused
OctaFloare
reviewed
Jul 12, 2024
| className="w-96 px-3 py-2 border border-white-300 rounded-lg focus:outline-none focus:ring-2 focus:ring-blue-500" | ||
| as="select" | ||
| name="genres.id" | ||
| onChange={(e) => { |
Owner
There was a problem hiding this comment.
It's a good practice for long logic like this to be extracted into a separate function
OctaFloare
reviewed
Jul 12, 2024
Owner
OctaFloare
left a comment
OctaFloare
left a comment
There was a problem hiding this comment.
Awesome work. Nice job handling the touched fields as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt of making this form.
Also Yup Schema Validation added to this form