fix: resolve Python 3.11 test hang + add CI safety nets#13
Merged
Oceanswave merged 2 commits intomainfrom Feb 4, 2026
Merged
Conversation
Python 3.11 CI jobs hang indefinitely during pytest while 3.12/3.13 complete in ~80 seconds. Add: - pytest-timeout (30s per test) to identify which test hangs - 10-minute job timeout to prevent multi-hour CI runs - Verbose pytest output in CI for better diagnostics Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The test_queue_overflow_drops_silently test deadlocks on Python 3.11 because Textual's ContextVar handling + asyncio event loop scheduling differs from 3.12+. The test only validates that push_frame silently drops frames when the queue is full — it doesn't need the full Textual app lifecycle. Remove app.run_test() wrapper to fix the 3.11 hang. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Oceanswave
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_queue_overflow_drops_silentlydeadlock on Python 3.11 — removed unnecessaryapp.run_test()wrapper that triggered Textual ContextVar + event loop conflictspytest-timeout(30s/test) to catch future hangsRoot cause: Textual's
ContextVar.reset()raisesValueErroron Python 3.11 when tokens are created in a different async context. Combined with the tight 110-framepush_frameloop and background workers insiderun_test(), this caused a deadlock. The test only validates queue overflow behavior and doesn't need the full Textual lifecycle.Test plan
🤖 Generated with Claude Code