Skip to content

Conversation

@wiitt
Copy link
Collaborator

@wiitt wiitt commented Mar 19, 2025

Fixes #39
This PR creates an updated toolbox package. Also, it moves docs so they are in scope of toolbox.

If packaging the toolbox has been made correctly, FileExchange needs to be updated (I guess we might need to trigger release).

Also move docs so they are in scope of toolbox
onc.prj Outdated
Github repository: https://github.com/OceanNetworksCanada/api-matlab-client
GitHub Repository: https://github.com/OceanNetworksCanada/api-matlab-client

Current Maintainer: Zelalem Engida, Angela Schlesinger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Current Maintainer(s) section here should probably be updated. Ze no longer works at ONC, so I'd move their name to the Past Contributors section. I'd keep Angela's name here, she overlooks API development in general.

I'm not sure who will be picking up maintaining the Matlab client library in the future though. Possibly the next intermediate/senior scientific programmer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a list of maintainers is also mentioned in: https://github.com/OceanNetworksCanada/api-matlab-client/blob/main/README.md

Copy link
Contributor

@spencerwplovie spencerwplovie Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a separate ticket/changeset, it might also be worth updating the Contributing markdown file as well: https://github.com/OceanNetworksCanada/api-matlab-client/blob/main/CONTRIBUTING.md
The first paragraph under the header could be simplified to more closely match what we have in our Python client library: https://github.com/OceanNetworksCanada/api-python-client/blob/main/CONTRIBUTING.md

Also, we do now use GitHub Integration for this repository, so the Overview section should be updated as well. Hmm reading through the new toolkit version process at the bottom, the section about uploading to FileExchange is outdated as well. Should match the steps I added to the CL Release Procedure page in our internal docs. I think that last bit should just be deleted so we don't need to maintain this in two separate spaces - only internal users should have access to the ONC FileExchange account, anyways.

@spencerwplovie
Copy link
Contributor

spencerwplovie commented Mar 26, 2025

When you get to the stage of updating the FileExchange, follow the CL Release Procedure page in our internal docs. If it doesn't work as expected, let me know. You'll need to make sure that in step 3.5 the FileExchange is tracking by release; I changed that by accident last time I published and couldn't change it back without making a new release.

@wiitt wiitt requested a review from spencerwplovie April 14, 2025 16:07
@wiitt wiitt merged commit a71f9eb into main Apr 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update toolbox and make release

3 participants