Skip to content

Conversation

@antoinemadec
Copy link
Contributor

@antoinemadec antoinemadec commented May 6, 2025

repro

  1. :highlight
  2. :q
  3. resize

It was only working fine when pressing q thanks to the callback.

questions

Why do we want to hide the list_window instead of closing it in the first place?

I don't understand why we allocate and hide so many windows in the 1st place (I might be missing something here)?

It seems to be adding a lot of complexity and corner cases in the code.

@OXY2DEV
Copy link
Owner

OXY2DEV commented May 6, 2025

Why do we want to hide the list_window instead of closing it in the first place?

For some reason, certain UI events prevent screen updates. So if I open a window, there's a chance the user wouldn't even see it until the screen updates again.

Plus in some cases, it just keeps erroring out in the background.

I don't understand why we allocate and hide so many windows in the 1st place.

Because sometimes even the most randomest things prevent windows from opening or showing up on the screen.

To get around this, hidden windows are used as they can immediately show the changes, unlike opening windows which doesn't show up on screen immediately.

Also, changing tabs gives weird side effects(mainly when closing windows from other tabs).

@OXY2DEV OXY2DEV merged commit c09c27f into OXY2DEV:main May 6, 2025
1 check passed
OXY2DEV added a commit that referenced this pull request May 6, 2025
@OXY2DEV OXY2DEV mentioned this pull request May 6, 2025
@OXY2DEV
Copy link
Owner

OXY2DEV commented May 6, 2025

Okay, the issue with creating way too many windows is fixed.

See if you encounter any bugs or strange behavior.

OXY2DEV added a commit that referenced this pull request May 6, 2025
OXY2DEV added a commit that referenced this pull request May 6, 2025
OXY2DEV added a commit that referenced this pull request May 6, 2025
OXY2DEV added a commit that referenced this pull request May 6, 2025
OXY2DEV added a commit that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants