Skip to content

Conversation

@cgsmith
Copy link
Contributor

@cgsmith cgsmith commented Jan 20, 2025

I found a couple other issues which are corrected in this PR.

  • Fix incorrect namespace on AmazonService, UserComponent, OrderList
    - Removed calls to deprecated DatabaseProvider and replaced with QueryBuilderInterface
  • Removed unused namespaces in code
  • Add .idea to .gitignore
  • Add different GitHub workflows for phpcs, phpmd, and phpstan

@Sieg Sieg added the internal label Jan 21, 2025
@cgsmith
Copy link
Contributor Author

cgsmith commented Jan 21, 2025

Added DatabaseProvider back in per @mariolorenz email about OXID 6.1 compatibility.

Just a note. I tried to get the GitHub workflows fixed but had issues and am not sure why. The PHPCS, PHPMD, and phpstan all work locally for me but for some reason fail on the workflows.

I also split out the phpcs, phpmd, and phpstan actions in separate yaml files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants