Preserve order of rel attributes (#336) #352
Open
+30
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
approved these changes
Feb 25, 2025
Author
|
Ping @mikesamuel can this please be merged and released? |
Author
|
@jmanico @mikesamuel Kindly requesting a review. |
Author
|
@melloware @aalmiray @jmanico Sorry for the broad ping but I just noticed that the project got some activity again and kindly wanted to raise attention for my regression fix proposed here. |
Contributor
|
I have no control but I would love to see some of these PRs merged as well |
aalmiray
force-pushed
the
main
branch
5 times, most recently
from
9bb458a to
f40152f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression introduced in
20240325.1- see #336 for details.LinkedHashSetto preserve insertion order where applicable - please note that there may be more regressions like this that have not yet been uncovered