Bulk interface update #433

church29 · 2013-11-01T00:06:30Z

As mentioned in #426

church29 · 2013-11-01T08:25:14Z

media/js/tables.js

Remove editable table mode*

akeym · 2013-11-04T21:07:28Z

batch update form shows when there aren't any interfaces in the zone (like, a zone without dynamic interfaces, or static). It shows the create an interface form, as well as the batch update form below it.

should restrict ranges based on user permissions as well.

church29 · 2013-11-04T21:26:43Z

Missing a form.make_usable(request) call in base/views

_usable to batchupdateform

…Update

… Batch_Update

…Update

…ting

church29 · 2014-06-20T22:07:48Z

This has been good to for a while, someone should test it though.

church29 · 2014-12-01T21:30:03Z

I will be getting this up to date after #710 is completed.

…Update Conflicts: cyder/cydhcp/interface/urls.py cyder/cydhcp/interface/views.py cyder/templates/cydhcp/cydhcp_view.html media/js/tables.js

church29 · 2015-01-23T00:12:16Z

This seems to be working still. I just need to clean it all up a bit.

drkitty · 2015-02-04T23:28:53Z

Intriguing. A couple comments:

The checkbox label ("Enter batch update mode") is in the imperative, which feels a little weird and doesn't make sense when the box is checked and I'm in batch update mode.
Is it possible to make the selection checkboxes bigger? Their small size gets annoying when I'm trying to check several boxes in a row.

drkitty · 2015-02-04T23:31:26Z

If I try to move an interface that can't be moved (like a glue record), the ValidationError propagates all the way up to the view, causing a server error.

drkitty · 2015-02-04T23:35:26Z

In the dynamic interface list page, there are non-breaking spaces before and after each IP range in the range column (I don't know why). When I enter batch update mode, they show up as " ".

drkitty · 2015-02-05T00:03:37Z

cyder/cydhcp/interface/views.py

You might consider rolling back the transaction here instead of manually deleting things. If not, you need to at least handle ValidationErrors, although I'm not sure how that would work.

drkitty · 2015-02-05T00:08:05Z

When changing a dynamic interface to a static one, the name is constructed incorrectly. DynamicInterface.mac contains colons (unless you fetch it using values() or values_list()).

drkitty · 2015-02-05T00:21:29Z

Under certain circumstances, the view attempts to create a static interface whose container doesn't match its domain. It happened when I created a dynamic interface in zone.ace in the dynamic range 10.255.255.255 – 10.255.255.255 and then tried to move it to the static range 128.193.82.2 - 128.193.82.126. I haven't pinned down the cause, though.

church29 · 2015-02-16T22:02:07Z

This is going to be a little more tricky than I planned.

akeym · 2015-03-07T01:01:29Z

Is this still in please review status?

Initial js for batch update

506808b

ghost assigned akeym Nov 1, 2013

Setup js to sent post data to batch_update

55bffaf

church29 reviewed Nov 1, 2013
View reviewed changes

media/js/tables.js Outdated

Copy link

Contributor Author

church29 Nov 1, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove editable table mode*

Implemented updating range for dynamic interfaces

f3c072b

church29 added 23 commits November 23, 2013 15:12

Fixed comment in js, added make

cd50ea2

_usable to batchupdateform

Merge branch 'master' of https://github.com/OSU-Net/cyder into Batch_…

7dc4d62

…Update

Merge branch 'master' of https://github.com/OSU-Net/cyder into Batch_…

b5a4315

…Update

Dont display bulk update form if not objects in ctnr

79f10c2

Merge branch 'master' of https://github.com/OSU-Net/cyder into Batch_…

475b0c8

…Update

Added range type selector for batch update form

138be46

range_type now submits along with the form through ajax

971c0db

Merge branch 'master' of https://github.com/OSU-Net/cyder into Batch_…

18e329a

…Update

Merge branch 'master' of https://github.com/OSU-Net/cyder into Batch_…

3009ab1

…Update

Update batch_update to handle range_type not being selected

c4a6ca4

Merge branch 'Batch_Update' of https://github.com/church29/cyder into…

8f95e46

… Batch_Update

Can now filter ranges by type

1366a6c

Added url for get_ranges

0d4928d

Refactor interface/views

7781b05

Can now migrate static interfaces between static ranges

99c34de

Added site to batch update form

ee42993

Merge branch 'master' of https://github.com/OSU-Net/cyder into Batch_…

1416495

…Update

Merge branch 'master' of https://github.com/OSU-Net/cyder into Batch_…

79aca71

…Update

A little refactoring to make batch update more robust

17ecf4d

Fixed batch update not working if site is not selected

a3b2c69

Can now migrate static interfaces to dynamic interfaces

fc05351

can now migrate from dynamic interfaces to static interfaces

30dfdcd

Fixed issue with interfaces being assigned the same ip and not valida…

96f9a4a

…ting

church29 added 5 commits January 22, 2015 15:05

Merge branch 'master' of https://github.com/OSU-Net/cyder into Batch_…

3c48c91

…Update Conflicts: cyder/cydhcp/interface/urls.py cyder/cydhcp/interface/views.py cyder/templates/cydhcp/cydhcp_view.html media/js/tables.js

Fix error due to missing endif tag

f7e16ee

Minor bug fixes

2e609e6

Light formatting

7fdeb9f

Remove accidentally added imgs

8832fad

church29 added 6 commits January 27, 2015 13:06

Use already created get_ranges

bbe4840

Progress on refactoring batch_update

53144e5

Fix args for batch_update sub functions

fc43158

Switch from .post to .ajax

696f7cc

Dont manually call full clean

225ec4f

Styling for select all checkbox

2564b20

church29 added please review and removed please look labels Feb 3, 2015

drkitty assigned drkitty and unassigned akeym Feb 4, 2015

drkitty reviewed Feb 5, 2015
View reviewed changes

church29 added 2 commits February 16, 2015 14:28

Add exit batch update mode link and remove enable checkbox

b0a7fda

Increase size of checkboxes in batch-update table

25ec99d

drkitty added please look and removed please review labels Apr 2, 2015

Bulk interface update #433

Are you sure you want to change the base?

Bulk interface update #433

Uh oh!

Conversation

church29 commented Nov 1, 2013

Uh oh!

church29 Nov 1, 2013

Choose a reason for hiding this comment

Uh oh!

akeym commented Nov 4, 2013

Uh oh!

church29 commented Nov 4, 2013

Uh oh!

church29 commented Jun 20, 2014

Uh oh!

church29 commented Dec 1, 2014

Uh oh!

church29 commented Jan 23, 2015

Uh oh!

drkitty commented Feb 4, 2015

Uh oh!

drkitty commented Feb 4, 2015

Uh oh!

drkitty commented Feb 4, 2015

Uh oh!

drkitty Feb 5, 2015

Choose a reason for hiding this comment

Uh oh!

drkitty commented Feb 5, 2015

Uh oh!

drkitty commented Feb 5, 2015

Uh oh!

church29 commented Feb 16, 2015

Uh oh!

akeym commented Mar 7, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants