-
Notifications
You must be signed in to change notification settings - Fork 12
Rework config builders #1043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Rework config builders #1043
Conversation
|
So you're removing the |
|
Oops. |
|
Seems to work properly now. |
|
Why not sort the build files themselves? I'm assuming that, unlike DHCP builds, somewhere down the line someone is going to want to look at the DNS build files eventually. That's why we've added in buttons in Cyder to view the builds, and why we arrange each record into neatly aligned columns. |
|
Shouldn't need to do |
|
If we don't need to check the zone, there's certainly no reason to build it then. |
|
For some records, the TTL is written to builds as |
|
You migrated beforehand? |
Resolves issue #1002.
This branch ended up being much larger than I originally intended it to be, which is part of why it took so long.
Here's a one-liner to sort the zone files and normalize their whitespace to make comparison easier:
Major changes:
Minor changes:
bindbuildcommand todns_build, for better consistency with thedhcp_buildcommand. Let me know if that was a stupid idea.BINDBUILDdict is now calledDNSBUILDto match the other name changes.Option migration guide:
-f→-a(build All zones).-pwas removed; syncing to the prod directory is now the default unless-n(dry ruN) is passed.