Skip to content

Conversation

@Aarshpatel12
Copy link

Summary

This PR fixes the broken build system, allowing the test suite to run for the first time in years.

  • Passing Tests: 2326 passed (previously 0 ran due to errors).
  • Remaining Failures: 5 failures in LEK_Edinburgh_UK (appear to be logic type errors, distinct from build issues).

Changes

  1. Relaxed Numpy Constraints: Updated setup.py to allow numpy>=1.23.0 (fixing the missing rc2 version error).
  2. Fixed Deprecated Imports: Updated io.py to use pydicom instead of the obsolete dicom module.
  3. Fixed Import Paths: Updated 30+ test files to import from src instead of the non-existent osipi_code_collection package.
  4. Dependencies: Added joblib to requirements.

Motivation

I am an aspiring GSoC 2026 contributor. I noticed the CI/CD pipeline was broken and wanted to stabilize the base before working on new features.

@Aarshpatel12
Copy link
Author

Hi @ltorres6, just a quick follow-up on this! I've addressed the import path issues in the wrappers you pointed out and confirmed that the build is now stable with 2300+ tests passing.

Since this PR is a prerequisite for the Vanderbilt module updates (#102) and a few other features I've been working on, I'd appreciate it if you could take another look when you have a moment. Thanks!

@ltorres6
Copy link

ltorres6 commented Feb 2, 2026

@Aarshpatel12 there's a failing test/deploy job. Can you take a look?

Copy link
Author

@Aarshpatel12 Aarshpatel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ltorres6 The CI is now green! The failure was due to the environment missing the pydicom package. I've updated setup.py to include pydicom and removed the obsolete dicom dependency.

With 2300+ tests now passing, this PR is ready for merge. This will also fix the build issues for my other pending contributions (#102, etc.). Thank you for the guidance on the imports!

@Aarshpatel12
Copy link
Author

@ltorres6 It looks like the latest CI run was cancelled due to a GitHub infrastructure error ('Job not acquired'). I've verified the setup.py changes locally and they resolve the pydicom issue. Could you please re-run the 'Test and Deploy' job? Once that clears, the PR should be fully ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants