Skip to content

CI: add macOS app bundle distribution workflow#5118

Merged
nilason merged 1 commit intoOSGeo:mainfrom
nilason:add_mac_bundle_CI
Feb 18, 2025
Merged

CI: add macOS app bundle distribution workflow#5118
nilason merged 1 commit intoOSGeo:mainfrom
nilason:add_mac_bundle_CI

Conversation

@nilason
Copy link
Contributor

@nilason nilason commented Feb 14, 2025

Add macOS app bundle distribution workflow, which sign, notarise and package to a dmg file.

At this point it "only" creates a GH artefact, which remains available three days.

@nilason nilason added the macOS macOS specific label Feb 14, 2025
@nilason nilason added this to the 8.5.0 milestone Feb 14, 2025
@github-actions github-actions bot added the CI Continuous integration label Feb 14, 2025
@echoix
Copy link
Member

echoix commented Feb 14, 2025

Do we have other types of jobs that should run on the same triggers and we could group together in a "release.yml" workflow?

@nilason
Copy link
Contributor Author

nilason commented Feb 14, 2025

Do we have other types of jobs that should run on the same triggers and we could group together in a "release.yml" workflow?

Hopefully for Windows some time in the future, mid- to long-term. Definitely not in the short term.

@echoix
Copy link
Member

echoix commented Feb 14, 2025

Do we have other types of jobs that should run on the same triggers and we could group together in a "release.yml" workflow?

Hopefully for Windows some time in the future, mid- to long-term. Definitely not in the short term.

Related comment: #1212 (comment)

@echoix
Copy link
Member

echoix commented Feb 14, 2025

Does this workflow need to run as often in PRs (2min30) https://github.com/OSGeo/grass/actions/workflows/create_release_draft.yml

If we are to check if the release works once a week, on demand, plus on tags, checking release drafts is a good candidate

@nilason
Copy link
Contributor Author

nilason commented Feb 14, 2025

This is definitely not anything for PRs, and this artefact part will hopefully be replaced soon by an "upload to distribution server" step.

@echoix
Copy link
Member

echoix commented Feb 14, 2025

This is definitely not anything for PRs, and this artefact part will hopefully be replaced soon by an "upload to distribution server" step.

Oh nice! Was this discussed somewhere I missed?

@nilason
Copy link
Contributor Author

nilason commented Feb 14, 2025

This is definitely not anything for PRs, and this artefact part will hopefully be replaced soon by an "upload to distribution server" step.

Oh nice! Was this discussed somewhere I missed?

There are two builds which take ~45 min (ARM) and ~105 min (x86_64), involving uploading the whole package ~650 MB to Apple's server two time for each, so PRs are excluded from this. The upload to server part is my aim, which still have technical challenges to solve.

@wenzeslaus
Copy link
Member

Does this workflow need to run as often in PRs (2min30) https://github.com/OSGeo/grass/actions/workflows/create_release_draft.yml

If we are to check if the release works once a week, on demand, plus on tags, checking release drafts is a good candidate

I think I made the release draft for each PR because PR would break the release workflow. I wanted and still want to simplify the release procedure as much as possible. Over years the release procedure accumulated ton of steps which were "let's just check this before the release" which resulted in extremely tedious list of steps.

Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no harm in trying it out, but I'd hope to see a consolidation of release jobs together if possible some day.

@nilason nilason merged commit 2854e29 into OSGeo:main Feb 18, 2025
28 checks passed
@nilason
Copy link
Contributor Author

nilason commented Feb 20, 2025

@nilason nilason deleted the add_mac_bundle_CI branch March 14, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration macOS macOS specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants