Conversation
wenzeslaus
left a comment
There was a problem hiding this comment.
This looks reasonable. I have some documentation and stylistic notes.
f1e11da to
53baae9
Compare
wenzeslaus
left a comment
There was a problem hiding this comment.
As far as the code goes, this is good to go.
|
A related test for TGIS mapset access is failing. This needs to be fixed first before merging. |
This will require a bit more effort because GRASS TGIS still expects at various different places that a raster/raster3d/vector map can only be registered in a TGIS db in the same mapset where this map is located. This prevents registering maps from a different mapset in a space-time dataset in the current mapset and subsequent modifications of this space-time dataset in the current mapset. A solution would be to not only store information about the mapset of a map, but also information about the mapset of the space-time dataset that is currently used and where this map is registered in the internal structures of the temporal framework. The historical background is that a map could only be registered in a space-time dataset if both are in the current mapset. |
|
At this point, this seems like something for 8.4.0. |
|
@metzm shall I bump this PR to 8.4.0? |
22e8ba7 to
e0692ae
Compare
b89d46f to
36eb604
Compare
|
@metzm Please consider merging this PR. |
|
I tried to solve conflicts, but I couldn't make sense of the changes in regards to changing self.mapset to self.data_mapset, that didn't seem used correctly. So I aborted it. |
Sometimes only the current mapset must be used by TGIS, particularly if the TGIS db is going to be modified. TGIS dbs in other mapsets can/should not be modified, only queried.
This PR adds functionality to initialize a
SQLDatabaseInterfaceConnectionwith only the current mapset.