This repository was archived by the owner on May 13, 2025. It is now read-only.
Filter placeholder suggests selection of a file#217
Merged
johrstrom merged 1 commit intoOSC:masterfrom May 13, 2025
Merged
Conversation
bedroesb
changed the title
Contributor
|
I can merge this and kinda prey the workflows run, but afterwards I'm going to archive this repository as it's not supported anymore. OnDemand 3.1 shipped with the Here's the documentation link for reference: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current placeholder value for the filter is file.txt, which looks confusing when the file picker is in "dir mode". Some thing more generic like search or nothing at all would make more sense to me.