Add possibility to pass extra yaml files to explorer launches #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegMll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to add a 2nd yaml file to the controller manager both in simulation and on real hardware. For future work, it will allow all people from the project to just pass their config file for their custom controller to the robot launch, without modifying explore_description.
Their is also a small change in orthopus_vesc, because the operator *= for rclcpp::Duration and double was introduced in iron, and i wanted to compile it with humble. i can remove it, from the pr if needed.
And it also put the orthopus_vesc submodule with a absolute, path, otherwise forks of this repo are complicated