RAS-1797 SEFT Upload Error Message Behaviour #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJBabbage
commented
Jan 27, 2026
LJBabbage
commented
Jan 27, 2026
Contributor
matthew-robinson-ons
left a comment
matthew-robinson-ons
left a comment
There was a problem hiding this comment.
Coverage looks good and the rework of the tests. The correct errors are shown individually and when there are multiple errors. As well as the stripping out of redundant code. Couple queries about the text of the last acceptance criteria and a variable name.
arroyoAle
approved these changes
Jan 30, 2026
Contributor
arroyoAle
left a comment
arroyoAle
left a comment
There was a problem hiding this comment.
Functionally works as expected for one or multiple errors, test coverage looks good. Agree with the other comments about following the design system and variable names
matthew-robinson-ons
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Fixes the upload errors and allows multiple to be shown. I have rationalised the validation to one place and removed unnecessary code. I have also moved the majority of tests from view to unit as they should always have been. Extra tests have also been added as coverage was poor
How to test?
Create a SEFT CE and try uploading different files which would break validation
Jira