Skip to content

some minor changes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OMaluhaCodacy wants to merge 10 commits into
base: main
Choose a base branch
from
Open

some minor changes #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8650e89
some minor changes
OMaluhaCodacy Nov 25, 2022
645fe22
some minor changes 2
OMaluhaCodacy Nov 30, 2022
39a3b25
some minor changes 3
OMaluhaCodacy Dec 29, 2022
e5be00c
some minor changes 4
OMaluhaCodacy Dec 29, 2022
d4775a9
some minor changes 4
OMaluhaCodacy Dec 29, 2022
3be913b
some minor changes 5
OMaluhaCodacy Dec 29, 2022
faee7fe
some minor changes 6
OMaluhaCodacy Dec 29, 2022
7b21290
some minor changes 7
OMaluhaCodacy Dec 29, 2022
d72a1a2
some minor changes 8
OMaluhaCodacy Dec 29, 2022
3e8fcdd
some minor changes 9
OMaluhaCodacy Dec 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/main/java/com/codacy/utils/Math.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,23 @@
public class Math {

private int magicNumber;
int some = 1;

public Math(int magicNumber) {
this.magicNumber = magicNumber;
}

/**
* Adds 2 numbers, unless there is a magic number on the second argument
*/
public int magicAdd(int x, int y) {
if (y == magicNumber) {
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
Expand All @@ -21,6 +28,13 @@ public int magicAdd(int x, int y) {
System.out.println("hey");
return y - x;
} else {
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
Expand Down
7 changes: 2 additions & 5 deletions src/main/java/com/codacy/utils/Math2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ public class Math2 {
public Math2(int magicNumber) {
this.magicNumber = magicNumber;
}

/**
* Adds 2 numbers, unless there is a magic number on the second argument
*/
Expand All @@ -16,8 +15,7 @@ public int magicAdd(int x, int y) {
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");;;;
System.out.println("hey");
return y - x;
} else {
Expand All @@ -36,8 +34,7 @@ public int magicAdd(int x, int y) {
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
System.out.println("hey");
return x + y;
return y + x;
}
}
}
10 changes: 5 additions & 5 deletions src/test/java/com/codacy/utils/Math2Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ public void shouldAddNumbers() {
}

// Uncomment this to have 100% coverage
@Test
public void shouldSubtractIfMagicNumber() {
Math2 math = new Math2(4);
assertEquals(1, math.magicAdd(3, 4));
}
// @Test
// public void shouldSubtractIfMagicNumber() {
// Math2 math = new Math2(4);
// assertEquals(1, math.magicAdd(3, 4));
// }
}